fix(miner): page contribution-profile label fetches past 100 (#8010) by andriypolanski · Pull Request #8040 · JSONbored/loopover

andriypolanski · 2026-07-22T14:48:39Z

Summary

extractContributionProfile fetched /labels?per_page=100 once, so repos with >100 labels silently dropped eligibility/exclusion signals past page 1.
Label fetch now follows Link: rel="next" with the same page= loop shape as ci-poller.ts check-run pagination, fail-open on a later-page failure.

Closes #8010

Scope

The PR title follows type(scope): short summary Conventional Commit format, for example fix(api): restore profile access checks.
This PR is focused and does not mix unrelated backend, UI, MCP, docs, dependency, and deploy changes.
This follows CONTRIBUTING.md and does not reintroduce GitHub Pages, VitePress, site/, or CNAME.
I linked a currently open issue this PR resolves (e.g. Closes #123) — a linked open issue is required for every contributor PR.

Validation

If any required check was skipped, explain why:

Miner lib change only. Ran build:miner + the contribution-profile-extract suite with coverage. Full test:ci not re-run here.

Safety

No secrets, wallet details, hotkeys, coldkeys, user PATs, private keys, raw trust scores, private rankings, or private maintainer evidence are exposed.
Public GitHub text stays sanitized, low-noise, and does not imply compensation guarantees or optimization tactics.
Auth, cookie, CORS, GitHub App, Cloudflare, or session changes include negative-path tests.
API/OpenAPI/MCP behavior is updated and tested where needed.
UI changes use live API data or real empty/error/loading states, not production mock/demo fallbacks.
Visible UI changes include a UI Evidence section below with JPG/JPEG or PNG screenshots arranged as organized, captioned, clickable thumbnails. SVG screenshots are not used as review evidence. Review-only screenshots or recordings are not committed to the repository.
Public docs/changelogs are updated where needed; changelogs are only edited for release-prep PRs.

UI Evidence

N/A — miner lib pagination; no UI.

Notes

Required pattern: ci-poller.ts hasNextLink + page= loop.
≤100-label repos unchanged (no rel=next → single page).

…ed#8010) Follow GitHub Link rel=next the same way ci-poller pages check-runs so extractContributionProfile sees the full label set, not only page one. Co-authored-by: Cursor <cursoragent@cursor.com>

superagent-security · 2026-07-22T14:49:31Z

Superagent didn't find any vulnerabilities or security issues in this PR.

loopover-orb · 2026-07-22T14:53:50Z

Tip

✅ LoopOver review result - approve/merge recommended

_{Review updated: 2026-07-22 14:54:08 UTC}

2 files · 1 AI reviewer · no blockers · readiness 95/100 · CI green · clean

✅ Suggested Action - Approve/Merge

safe to merge

Review summary
This PR correctly fixes the label-fetch pagination bug: `fetchRepoLabels` now loops over `page=` parameters following the `Link: rel="next"` header, matching the existing `ci-poller.ts` pagination shape, and preserves the fail-open contract on a null/non-array/failed page. The bounded 50-page cap prevents runaway loops, and the empty-page guard prevents an infinite loop against a malformed API that keeps advertising `rel="next"` on an empty page. Test coverage is thorough, covering the happy path, fail-open on a later-page failure, empty-array termination, and non-array termination — all four new branches in `fetchRepoLabels` are exercised.

Nits — 5 non-blocking

`hasNextLink` in contribution-profile-extract.ts:127-131 assumes `response.headers.get` always exists, defended only by a `typeof` check — worth a one-line comment noting why the guard exists (a stub Response in some test path lacking `.get`) since it's not obvious from the surrounding code.
The compiled `.js` sibling file shown in context (`contribution-profile-extract.js`) has not been regenerated to match the new pagination logic — confirm the build step that produces it runs before this ships, since the checklist only ticks `build:miner` not a diff of the generated output.
`MAX_LABEL_PAGES = 50` (contribution-profile-extract.ts:139) is a reasonable but arbitrary cap; consider a one-line note on why 50×100=5000 was chosen over, e.g., matching whatever cap `opportunity-fanout.js` uses verbatim, for consistency.
Consider extracting the repeated `emptyHeaders` object literal across the many test cases in contribution-profile-extract.test.ts into a single shared test helper/constant to cut duplication.
The `getJsonResponse`/`getJson` split (contribution-profile-extract.ts:104-125) is clean; verify no other call site of the old `getJson` signature was relying on it returning the response object (looks confined to `fetchContributing`, which is fine).

Decision drivers

✅ Code review — No blockers (1 reviewer)
✅ Gate result — Passing (No configured blocker found.)

Context & advisory signals — never blocks the verdict

Signal	Result	Evidence
Linked issue	✅ Linked	#8010
Related work	✅ No active overlap found	No same-issue or scoped active PR overlap found.
Change scope	✅ 20/20	Low review scope from cached public metadata (1 linked issue).
Validation posture	✅ 25/25	PR body includes validation/test evidence.
Contributor workload	✅ 10/10	Author activity: 205 registered-repo PR(s), 128 merged, 22 issue(s).
Contributor context	✅ Confirmed Gittensor contributor	andriypolanski; Gittensor profile; 205 PR(s), 22 issue(s).
Improvement	✅ Minor	risk: clean · value: minor · LLM: moderate

Linked issue satisfaction

Addressed
The diff replaces the single-shot labels fetch with fetchRepoLabels, which loops with page= params and follows the Link rel="next" header (mirroring ci-poller's pagination convention) until exhausted, fail-open, or capped, directly fixing the >100-label truncation described in the issue.

Review context

Author: andriypolanski
Role context: outside_contributor
Public audience mode: oss maintainer
Lane context: Repository is configured for direct PR review.
Public profile languages: Python, TypeScript, JavaScript, Rust, Cuda, Kotlin, MDX, Scala
Official Gittensor activity: 205 PR(s), 22 issue(s).
PR-specific overlap: none found.

Contributor next steps

Start here: Triage stale or unlinked PRs.

Signal definitions

Related work = same linked issue, overlapping active PRs, or title/path similarity.
Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.

🧪 Chat with LoopOver

Ask LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.

@loopover ask <question> answers contribution-quality Q&A with source citations and freshness.
@loopover chat <question> answers in natural prose from cached decision-pack facts via local inference (maintainer/collaborator; read-only).
A plain-language @loopover mention with a real question is routed to the closest matching read-only command automatically — no exact syntax required.

Full command reference: https://loopover.ai/docs/loopover-commands

🧪 Experimental — new and may change.

_{🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed}

💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.

Re-run LoopOver review

loopover-orb

LoopOver approves — the gate is satisfied and CI is green.

fix(miner): page contribution-profile label fetches past 100 (JSONbor…

3e38796

…ed#8010) Follow GitHub Link rel=next the same way ci-poller pages check-runs so extractContributionProfile sees the full label set, not only page one. Co-authored-by: Cursor <cursoragent@cursor.com>

andriypolanski requested a review from JSONbored as a code owner July 22, 2026 14:48

loopover-orb Bot added the gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. label Jul 22, 2026

loopover-orb Bot assigned andriypolanski Jul 22, 2026

loopover-orb Bot approved these changes Jul 22, 2026

View reviewed changes

loopover-orb Bot merged commit 75daa84 into JSONbored:main Jul 22, 2026
10 checks passed

This was referenced Jul 23, 2026

chore(main): release engine-and-dependents libraries #8146

Merged

chore(main): release engine-and-dependents libraries #8249

Merged

fix(queue): retry a transient GitHub mergeable_state read before deferring to the next sweep #8560

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(miner): page contribution-profile label fetches past 100 (#8010)#8040

fix(miner): page contribution-profile label fetches past 100 (#8010)#8040
loopover-orb[bot] merged 1 commit into
JSONbored:mainfrom
andriypolanski:fix/8010-contribution-profile-label-pagination

andriypolanski commented Jul 22, 2026

Uh oh!

superagent-security Bot commented Jul 22, 2026

Uh oh!

loopover-orb Bot commented Jul 22, 2026 •

edited

Loading

✅ LoopOver review result - approve/merge recommended

Uh oh!

loopover-orb Bot left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

andriypolanski commented Jul 22, 2026

Summary

Scope

Validation

Safety

UI Evidence

Notes

Uh oh!

superagent-security Bot commented Jul 22, 2026

Uh oh!

loopover-orb Bot commented Jul 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ LoopOver review result - approve/merge recommended

Uh oh!

loopover-orb Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

loopover-orb Bot commented Jul 22, 2026 •

edited

Loading